Add SOC% plausibility detection #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matvey83
reviewed
Nov 21, 2023
| @@ -241,6 +241,14 @@ void update_values_leaf_battery() { /* This function maps all the values fetched | |||
| max_target_discharge_power = 0; | |||
| } | |||
|
|
|||
| //Check if SOC% is plausible | |||
| if (battery_voltage > (ABSOLUTE_MAX_VOLTAGE - 100)) { | |||
There was a problem hiding this comment.
Why deduct 10V from ABSOLUTE_MAX_VOLTAGE?
A comment explaining that would be nice.
There was a problem hiding this comment.
Oh I see, so if the battery voltage is almost 100% but SOC is under 65% we report an error. Perhaps a comment explaining this, and why this range was chosen would be helpful.
rjsc
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds plausibility checks for SOC% on Nissan LEAFs batteries.
Why
Using a Nissan LEAF battery below 1A for extended periods of times will cause the BMS to not calculate SOC% correctly. This can happen for instance when using a Checkwatt profile. When this happens, the BMS needs to be rebooted.
How
We check that if the battery voltage is close to max, and the SOC% is low, we raise a FAULT(red LED) to stop charging/discharging. We also send a message on the USB to inform the user what has happened, so they can take action.